-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update incremental-models.md #6283
Conversation
Make it clear that models do not fail on null values in the unique key.
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
@louisdvs is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @louisdvs , thanks for opening this up and clarifying! we've tweaked it a bit and happy to merge this for you!
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
What are you changing in this pull request and why?
Make it clear that model runs do not fail based on the presence of null values in the unique key.
This distinction is critical as we discovered when a model blew out over time and caused pipeline failure.
Where nulls exist, the merge silently inserts an additional row/s rather than failing the run.
Checklist