Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incremental-models.md #6283

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Update incremental-models.md #6283

merged 4 commits into from
Oct 16, 2024

Conversation

louisdvs
Copy link
Contributor

@louisdvs louisdvs commented Oct 14, 2024

What are you changing in this pull request and why?

Make it clear that model runs do not fail based on the presence of null values in the unique key.

This distinction is critical as we discovered when a model blew out over time and caused pipeline failure.

Where nulls exist, the merge silently inserts an additional row/s rather than failing the run.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Make it clear that models do not fail on null values in the unique key.
@louisdvs louisdvs requested a review from a team as a code owner October 14, 2024 04:22
Copy link

welcome bot commented Oct 14, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Oct 14, 2024

@louisdvs is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Oct 14, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 14, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Oct 14, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @louisdvs , thanks for opening this up and clarifying! we've tweaked it a bit and happy to merge this for you!

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 16, 2024 10:51am

@mirnawong1 mirnawong1 merged commit bc634cb into dbt-labs:current Oct 16, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants