Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Referenced node in defer #6276

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Referenced node in defer #6276

merged 1 commit into from
Oct 11, 2024

Conversation

dbeatty10
Copy link
Contributor

What are you changing in this pull request and why?

The docs here currently say:

  1. Is the referenced node included in the model selection criteria of the current run?
  2. Does the reference node exist as a database object in the current environment?

Since it seems like both items should have the same language, I'm guessing the latter was intended to say "referenced node".

Checklist

@vercel Vercel
Copy link

vercel bot commented Oct 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 10, 2024 11:54pm

@dbeatty10 dbeatty10 marked this pull request as ready for review October 10, 2024 23:51
@dbeatty10 dbeatty10 requested a review from a team as a code owner October 10, 2024 23:51
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 10, 2024
mirnawong1
mirnawong1 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch, thank you @dbeatty10 !

@mirnawong1 mirnawong1 merged commit 5f29a5e into current Oct 11, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-1 branch October 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbeatty10 @mirnawong1