Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update incremental-microbatch.md #6269

Merged

Conversation

alexisweill
Copy link
Contributor

@alexisweill alexisweill commented Oct 9, 2024

What are you changing in this pull request and why?

There is a typo in the example config for microbatch
event_time is updated from session_start to page_view_start

Checklist

Update config in example
`session_start` -> `page_view_start`
@alexisweill alexisweill requested a review from a team as a code owner October 9, 2024 21:03
Copy link

welcome bot commented Oct 9, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Oct 9, 2024

@alexisweill is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Oct 9, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 9, 2024
@mirnawong1
Copy link
Contributor

hey @alexisweill thanks for opening this pr up! i think session_start is correct bc it tells us when the whole visit to the website began. page_view_start i think focuses on individual page clicks, which isn't helpful when you're trying to understand the entire session.

however, let me confirm internally with the team and I'll get back to you here!

@alexisweill
Copy link
Contributor Author

@mirnawong1 thanks for checking - I think you are right! it might be worth clarifying in the surrounding text since session_start is only shown in the picture

add final select statement to show where `session_start` is coming from
clarify session_start
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 11, 2024
Copy link

vercel bot commented Oct 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 11, 2024 11:37am

@mirnawong1
Copy link
Contributor

mirnawong1 commented Oct 11, 2024

hey @alexisweill , thanks so much for your patience here! we've added a select statement example where session_start is coming from and a clarifying sentence.

@mirnawong1 mirnawong1 enabled auto-merge October 11, 2024 11:36
@mirnawong1 mirnawong1 merged commit f0c6d34 into dbt-labs:current Oct 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants