add 1.8 and lower version timespine #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
mirnawong1
commented
Oct 8, 2024
|
|
||
| <VersionBlock lastVersion="1.8"> | ||
|
|
||
| <!-- this whole section is for 1.8 and and lower --> |
There was a problem hiding this comment.
this is the v1.8 and lower section
mirnawong1
commented
Oct 8, 2024
| with hours as ( | ||
|
|
||
| {{ | ||
| dbt.date_spine( |
There was a problem hiding this comment.
should this be dbt_utils.date_spine for 1.6 and lower? and dbt.date_spine for 1.7 and higher?
There was a problem hiding this comment.
Oooo I'm actually not sure on this one!
| @@ -74,6 +76,7 @@ This example creates a time spine at an hourly grain and a daily grain: `time_sp | |||
|
|
|||
| <Lightbox src="/img/time_spines.png" width="50%" title="Time spine directory structure" /> | |||
|
|
|||
| <!-- | |||
There was a problem hiding this comment.
Is this commenting out the version block below?
There was a problem hiding this comment.
yes it is! but we dont need this yaml for 1.8 and lower right?
github-actions
bot
added
size: large
github-actions
bot
added
size: medium
github-actions
bot
added
size: large
courtneyholcomb
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds older content for 1.8 and lower to timespine docs in order to avoid user confusion.
slack thread here