Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New snapshot_meta_column_names config for dbt snapshots #6211

Merged
merged 43 commits into from
Oct 3, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Oct 2, 2024

Resolves #6112

What are you changing in this pull request and why?

In Versionless and dbt v1.9, we have a new snapshot_meta_column_names config for dbt snapshots that allows for customizing the column names of the snapshot meta fields (dbt_valid_from, dbt_valid_to, dbt_scd_id, dbt_updated_at) to align with team or organizational conventions.

For example, they can now have whichever column names you choose (e.g., valid_start, valid_end, scd_identifier, last_modified).

Previews

Checklist

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 3, 2024 5:36pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Oct 2, 2024
@dbeatty10 dbeatty10 changed the base branch from current to add/new-snapshot-spec-main October 2, 2024 14:06
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 2, 2024
@github-actions github-actions bot removed the size: small This change will take 1 to 2 days to address label Oct 2, 2024
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good - couple nit picks

website/docs/docs/build/snapshots.md Outdated Show resolved Hide resolved
website/docs/docs/dbt-versions/release-notes.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple final comments, but otherwise you have my approval :)

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Only a few tiny comments!

@dbeatty10 dbeatty10 changed the base branch from add/new-snapshot-spec-main to current October 3, 2024 17:17
@dbeatty10 dbeatty10 enabled auto-merge (squash) October 3, 2024 17:34
@dbeatty10 dbeatty10 merged commit f90259f into current Oct 3, 2024
6 checks passed
@dbeatty10 dbeatty10 deleted the dbeatty10-patch-1 branch October 3, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] New snapshot_meta_column_names config for dbt snapshots
4 participants