Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional ratio metric example #6209

Merged
merged 12 commits into from
Oct 7, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

this pr adds an additional ratio metric exmaple and explains the advanced keys for numerator/demonimator

slack thread

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 2, 2024 09:56
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 7, 2024 6:14pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed Docs team Authored by the Docs team @dbt Labs labels Oct 2, 2024
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Oct 2, 2024
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example looks great!! I gave one small recommendation inline

</File>

#### Example 2
This eample is a ratio metric that calculates the ratio of food orders to total orders, with a filter and alias applied to the numerator:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just add a note at the end here to make explicit how this is different, something like:
"...with a filter and alias applied to the numerator. Note that in order to add these attributes you'll need to use an explicit key for the name attribute, too."

@mirnawong1 mirnawong1 enabled auto-merge October 7, 2024 18:06
@mirnawong1 mirnawong1 merged commit ef9568a into current Oct 7, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the update-ratio-metrics branch October 7, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants