Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new spec to snapshot page #6188

Merged
merged 18 commits into from
Oct 3, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr contais the following:

  • rejigs the /docs/build/snapshots doc to introduce the new yaml config spec for snapshots
  • adds a new section for v1.8 and earlier config details

this pr should merge into the main add/new-snapshot-spec-main branch

@mirnawong1 mirnawong1 requested a review from a team as a code owner October 1, 2024 10:59
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com 🛑 Canceled (Inspect) Oct 3, 2024 5:20pm

@github-actions github-actions bot added content Improvements or additions to content size: large This change will more than a week to address and might require more than one person Docs team Authored by the Docs team @dbt Labs labels Oct 1, 2024
Copy link
Contributor

@dbeatty10 dbeatty10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One non-blocking sugg

Comment on lines 115 to 117
```yaml
-- models/ephemeral_orders.sql
{{ config(materialized='ephemeral') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the other examples, I'd suggest using <File ...>...</File> for the file named models/ephemeral_orders.sql and then remove the comment containing the file name.
`


<File name='models/changed_orders.sql'>
If you need to clean or transform your data before snapshotting, create an ephemeral model (or a staging model) that applies the necessary transformations. Then, reference this model in your snapshot configuration. This approach keeps your snapshot definitions clean and allows you to test and run transformations separately.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@mirnawong1 mirnawong1 merged commit 4e06cd2 into add/new-snapshot-spec-main Oct 3, 2024
3 of 4 checks passed
@mirnawong1 mirnawong1 deleted the add/new-snapshot-spec-docs branch October 3, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants