-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update set.md #6166
Update set.md #6166
Conversation
Added string example, It needs a single quote inside the double quote. to read a string. Otherwise, it was giving compilation error. Set is heavily used as a variable alternative.
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
@ameerulislam is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @ameerulislam , thank you for opening up this pr to enhance this section! going to merge this for you and looking forward to future contributions ✨
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alhamdulillah!!! this is a huge moment for me. I always wanted to contribute to open source and recently dbt has been my top choice. As I love this software so much. You just boosted my confidence, big time. |
Hi @mirnawong1 , I'm confused about one thing though. Why am I not shown as one of the contributors of the original repo after this PR merge? |
hey @ameerulislam , oh can you tell me where you're looking so i can investigate? |
Here |
hey @ameerulislam thanks for sharing! oh, so sorry but i think this may be the way GitHub presents information, unfortunately. if you look at the top of the page, it says:
which means if it didn't omit it, you'd probably show up in the 'per week' category? or it could be related to the reasons listed here too. but the good thing is that your great docs contributions should certainly contribute to your contributions graph in your own personal profile page: |
What are you changing in this pull request and why?
Added string example, It needs a single quote inside the double quote. to read a string. Otherwise, it was giving compilation error. Set is heavily used as a variable alternative.
Checklist