Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update set.md #6166

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Update set.md #6166

merged 3 commits into from
Sep 30, 2024

Conversation

ameerulislam
Copy link
Contributor

What are you changing in this pull request and why?

Added string example, It needs a single quote inside the double quote. to read a string. Otherwise, it was giving compilation error. Set is heavily used as a variable alternative.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Added string example, It needs a single quote inside the double quote. to read a string. Otherwise, it was giving compilation error. Set is heavily used as a variable alternative.
@ameerulislam ameerulislam requested a review from a team as a code owner September 29, 2024 06:47
Copy link

welcome bot commented Sep 29, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Sep 29, 2024

@ameerulislam is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Sep 29, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. and removed new contributor Label for first-time contributors labels Sep 29, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @ameerulislam , thank you for opening up this pr to enhance this section! going to merge this for you and looking forward to future contributions ✨

Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 30, 2024 8:30am

@mirnawong1 mirnawong1 merged commit 9e371c9 into dbt-labs:current Sep 30, 2024
2 of 3 checks passed
@ameerulislam
Copy link
Contributor Author

Alhamdulillah!!! this is a huge moment for me. I always wanted to contribute to open source and recently dbt has been my top choice. As I love this software so much. You just boosted my confidence, big time.
Thank You!

@ameerulislam
Copy link
Contributor Author

Hi @mirnawong1 , I'm confused about one thing though. Why am I not shown as one of the contributors of the original repo after this PR merge?

@mirnawong1
Copy link
Contributor

hey @ameerulislam , oh can you tell me where you're looking so i can investigate?

@ameerulislam
Copy link
Contributor Author

Here
https://github.com/dbt-labs/docs.getdbt.com/graphs/contributors?from=31%2F08%2F2024
with the period of last month. I thought I'll be present there but I'm not in there.

@mirnawong1
Copy link
Contributor

mirnawong1 commented Oct 2, 2024

hey @ameerulislam thanks for sharing! oh, so sorry but i think this may be the way GitHub presents information, unfortunately. if you look at the top of the page, it says:

Contributions per week to current, line counts have been omitted because commit count exceeds 10,000.

which means if it didn't omit it, you'd probably show up in the 'per week' category?

or it could be related to the reasons listed here too. but the good thing is that your great docs contributions should certainly contribute to your contributions graph in your own personal profile page:

Screenshot 2024-10-02 at 14 18 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants