Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax for require-dbt-version #6160

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

davidculley
Copy link
Contributor

What are you changing in this pull request and why?

Added missing quotes and the patch version.

Fixed these two errors:

  • 'float' object is not iterable
  • "1.5" is not a valid semantic version.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Added missing quotes and the patch version.

Fixed these two errors:
- `'float' object is not iterable`
- `"1.5" is not a valid semantic version.`
@davidculley davidculley requested a review from a team as a code owner September 26, 2024 17:43
Copy link

welcome bot commented Sep 26, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Sep 26, 2024

@davidculley is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@runleonarun runleonarun added the new contributor Label for first-time contributors label Sep 26, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Sep 26, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @davidculley ! appreciate you opening this up and will merge for you! ✨

@mirnawong1 mirnawong1 merged commit 711fc27 into dbt-labs:current Sep 27, 2024
9 of 11 checks passed
@davidculley
Copy link
Contributor Author

Thanks @mirnawong1!

@davidculley davidculley deleted the patch-1 branch September 28, 2024 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants