-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bidirectional proj deps #6137
Bidirectional proj deps #6137
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nghi-ly!
Could we also:
- remove the "beta" flag from where this is mentioned in the mesh guide here?
- add a release note?
Then I'll let you know when this is live-live in dbt Cloud so that we can merge!
Co-authored-by: Jeremy Cohen <[email protected]>
heya @jtcohen6 : i noticed a merge conflict and just fixed it. builds are passing again, woo. when you get a chance, can you review and, if it's good to go, approve? 🙏 |
website/docs/best-practices/how-we-mesh/mesh-2-who-is-dbt-mesh-for.md
Outdated
Show resolved
Hide resolved
@@ -1,14 +1,9 @@ | |||
Currently, the default behavior for "project" dependencies enforces that these relationships only go in one direction, meaning that the `jaffle_finance` project could not add a new model that depends, on any public models produced by the `jaffle_marketing` project. dbt will check for cycles across projects and raise errors if any are detected. | |||
You can enable bidirectional dependencies across projects so these relationships can go in either direction, meaning that the `jaffle_finance` project can add a new model that depends on any public models produced by the `jaffle_marketing` project, so long as the new dependency doesn't introduce any node-level cycles. dbt checks for cycles across projects and raises errors if any are detected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the placement of this snippet, that first sentence may not be descriptive enough. What relationships are we alluding to?
We're also using specific examples that aren't really anywhere else on the Mesh-5-faqs and Mesh-3-Structures pages that use the snippet. It might be better to use the same generic examples we use down on lines 9-12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's fair! open to any suggs you may have?
also, is this a blocker?
Co-authored-by: Matt Shaver <[email protected]>
What are you changing in this pull request and why?
GA docs for bidirectional project dependencies feature
Checklist
🚀 Deployment available! Here are the direct links to the updated files: