Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bidirectional proj deps #6137

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Bidirectional proj deps #6137

merged 11 commits into from
Oct 18, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 24, 2024

What are you changing in this pull request and why?

GA docs for bidirectional project dependencies feature

Checklist


🚀 Deployment available! Here are the direct links to the updated files:

@nghi-ly nghi-ly requested a review from a team as a code owner September 24, 2024 22:50
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 18, 2024 5:29pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. and removed Docs team Authored by the Docs team @dbt Labs labels Sep 24, 2024
@nghi-ly nghi-ly requested a review from jtcohen6 September 24, 2024 22:51
Copy link
Collaborator

@jtcohen6 jtcohen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nghi-ly!

Could we also:

Then I'll let you know when this is live-live in dbt Cloud so that we can merge!

website/snippets/_mesh-cycle-detection.md Outdated Show resolved Hide resolved
website/snippets/_mesh-cycle-detection.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs and removed Docs team Authored by the Docs team @dbt Labs labels Sep 26, 2024
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Oct 1, 2024
@nghi-ly
Copy link
Contributor Author

nghi-ly commented Oct 2, 2024

heya @jtcohen6 : i noticed a merge conflict and just fixed it. builds are passing again, woo. when you get a chance, can you review and, if it's good to go, approve? 🙏

@@ -1,14 +1,9 @@
Currently, the default behavior for "project" dependencies enforces that these relationships only go in one direction, meaning that the `jaffle_finance` project could not add a new model that depends, on any public models produced by the `jaffle_marketing` project. dbt will check for cycles across projects and raise errors if any are detected.
You can enable bidirectional dependencies across projects so these relationships can go in either direction, meaning that the `jaffle_finance` project can add a new model that depends on any public models produced by the `jaffle_marketing` project, so long as the new dependency doesn't introduce any node-level cycles. dbt checks for cycles across projects and raises errors if any are detected.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the placement of this snippet, that first sentence may not be descriptive enough. What relationships are we alluding to?

We're also using specific examples that aren't really anywhere else on the Mesh-5-faqs and Mesh-3-Structures pages that use the snippet. It might be better to use the same generic examples we use down on lines 9-12

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fair! open to any suggs you may have?

also, is this a blocker?

@nghi-ly nghi-ly merged commit d49eec8 into current Oct 18, 2024
9 checks passed
@nghi-ly nghi-ly deleted the ly-docs-bidir-proj-deps branch October 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants