Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old workarounds #6133

Merged
merged 9 commits into from
Sep 25, 2024
Merged

Remove old workarounds #6133

merged 9 commits into from
Sep 25, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Sep 24, 2024 •
edited
Loading

What are you changing in this pull request and why?

Remove target_schema workarounds since they no longer apply with v1.9+ native support for environment-aware snapshots.

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner September 24, 2024 20:11
@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 25, 2024 3:44pm

@nghi-ly nghi-ly requested review from graciegoheen and removed request for a team September 24, 2024 20:11
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address Docs team Authored by the Docs team @dbt Labs and removed content Improvements or additions to content labels Sep 24, 2024
graciegoheen
graciegoheen reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small tweaks otherwise looking good!

website/docs/reference/resource-configs/target_schema.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/target_schema.md Outdated Show resolved Hide resolved
website/docs/reference/resource-configs/target_schema.md Outdated Show resolved Hide resolved
graciegoheen
graciegoheen approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@graciegoheen graciegoheen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ly!

@nghi-ly nghi-ly requested a review from a team September 25, 2024 00:15
nataliefiann
nataliefiann approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @nghi-ly

Thanks for creating this PR. It was a nice read. I've approved this for you with no suggestions or recommendations.

Kind Regards
Natalie

@nghi-ly nghi-ly enabled auto-merge (squash) September 25, 2024 15:41
@nghi-ly nghi-ly merged commit 423e48f into current Sep 25, 2024
10 checks passed
@nghi-ly nghi-ly deleted the ly-docs-update-workarounds branch September 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@nataliefiann nataliefiann nataliefiann approved these changes

Assignees
No one assigned
Labels
Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nghi-ly @graciegoheen @nataliefiann