Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ci check that auto comments preview link #6128

Merged
merged 48 commits into from
Oct 15, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Sep 24, 2024

this pr adds a ci that auto-comments the staging link using the branch-name to make it easier for the author, reviewer, and any other viewer.

test pr: #6098

outstanding:

  • i'd like to change the github action yaml so that it picks up frontmatter id first and then file name since sometimes we use a diff id
  • i'd like to add a time delay os it posts after or around went vercel deploys
  • how will this interact with open source contributions w/o vercel access (will checks fair or output incorrect preview link)

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 24, 2024 13:58
Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 15, 2024 9:14am

@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Sep 24, 2024
@mirnawong1 mirnawong1 changed the title add ci check thata auto comments preview link add ci check that auto comments preview link Sep 24, 2024
@JKarlavige
Copy link
Collaborator

Hey @mirnawong1, looking into this now. Do you have a way for me to test this within this PR?

@mirnawong1
Copy link
Contributor Author

hey @JKarlavige ! i created a test pr #6098 to test it. so if you made changes to a file, it should post the link 🤞

Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirnawong1 this is great! Verified in PR #6098 a new preview link was added to the description after pushing an update. The preview URL added to the description was the correct page.

Awesome work with this, this is a great value add to these PRs!! :shipit:

@mirnawong1 mirnawong1 enabled auto-merge October 15, 2024 09:09
@mirnawong1 mirnawong1 merged commit ea4e61a into current Oct 15, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the mwong-add-preview-link branch October 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants