Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated breaking changes section #6119

Merged
merged 12 commits into from
Oct 1, 2024
Merged

Updated breaking changes section #6119

merged 12 commits into from
Oct 1, 2024

Conversation

nataliefiann
Copy link
Contributor

@nataliefiann nataliefiann commented Sep 23, 2024

Closes #5574

Following this Git issue: https://github.com/orgs/dbt-labs/projects/14/views/35?pane=issue&itemId=65030468, i've created this PR regarding the updated breaking changes

What are you changing in this pull request and why?

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@nataliefiann nataliefiann requested a review from a team as a code owner September 23, 2024 14:24
Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Oct 1, 2024 7:00pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Sep 23, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just suggesting to add some clarity to the warning/error here!

Also, should we revise the wording here to match your wording? https://docs.getdbt.com/reference/resource-properties/versions#detecting-breaking-changes

website/docs/docs/collaborate/govern/model-contracts.md Outdated Show resolved Hide resolved
website/docs/docs/collaborate/govern/model-contracts.md Outdated Show resolved Hide resolved
@nataliefiann
Copy link
Contributor Author

Closed off as Core project has been paused

@runleonarun runleonarun reopened this Oct 1, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can follow up on my comment

@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Oct 1, 2024
@dbeatty10
Copy link
Contributor

Just suggesting to add some clarity to the warning/error here!

Also, should we revise the wording here to match your wording? https://docs.getdbt.com/reference/resource-properties/versions#detecting-breaking-changes

Good catch! The relevant code is here.

I've opened up a docs issue in #6198 to see if these can be abstracted into a common snippet.

@dbeatty10 dbeatty10 enabled auto-merge (squash) October 1, 2024 18:57
@dbeatty10 dbeatty10 merged commit b7c883c into current Oct 1, 2024
10 checks passed
@dbeatty10 dbeatty10 deleted the nfiann-breaking-changes branch October 1, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Removing a contracted model now constitutes a breaking change
4 participants