-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated breaking changes section #6119
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
Co-authored-by: Matt Shaver <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just suggesting to add some clarity to the warning/error here!
Also, should we revise the wording here to match your wording? https://docs.getdbt.com/reference/resource-properties/versions#detecting-breaking-changes
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
Closed off as Core project has been paused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! We can follow up on my comment
Good catch! The relevant code is here. I've opened up a docs issue in #6198 to see if these can be abstracted into a common snippet. |
Closes #5574
Following this Git issue: https://github.com/orgs/dbt-labs/projects/14/views/35?pane=issue&itemId=65030468, i've created this PR regarding the updated breaking changes
What are you changing in this pull request and why?
Checklist