Added the snapshot / block displaying new config #6118
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
matthewshaver
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Hi Nat! Thanks for opening this. This looks good for core issue dbt-labs/dbt-core#4000 - we should also come back to this when doing the docs changes for dbt-labs/dbt-core#10246
As coming soon, you will be able to define snapshots entirely in yml files
graciegoheen
requested changes
Sep 23, 2024
nataliefiann
commented
Sep 26, 2024
nataliefiann
commented
Sep 26, 2024
nataliefiann
commented
Sep 26, 2024
mirnawong1
reviewed
Sep 30, 2024
Co-authored-by: Mirna Wong <[email protected]>
| @@ -80,11 +80,30 @@ snapshots: | |||
|
|
|||
| <TabItem value="property-yaml"> | |||
|
|
|||
| **Note:** Required snapshot properties _will not_ work when defined in `config` YAML blocks. We recommend that you define these in `dbt_project.yml` or a `config()` block within the snapshot `.sql` file. | |||
There was a problem hiding this comment.
This will still be true for versions before 1.9 - do we want to keep the callout for those earlier versions? Maybe add a recommendation to upgrade?
|
Note to self - add version block for users up to 1.8 |
|
Closed off as Core project has been paused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created this PR following this Git issue: https://github.com/orgs/dbt-labs/projects/14/views/35?pane=issue&itemId=66616463
Resolves #5627
I've added the snapshot / block displaying the new config
What are you changing in this pull request and why?
Checklist