Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing banners #6109

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Removing banners #6109

merged 1 commit into from
Sep 20, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Sep 20, 2024

What are you changing in this pull request and why?

This removes two edge case banners that are no longer required.

One banner is displayed if the user is on a page that is marked as lastversion in the dbt-versions file and the user changes to a higher version.

The other is if they are on a page that is marked as firstversion in. the dbt-versions file but the user changes to a lower, unsupported version.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner September 20, 2024 18:13
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 20, 2024 6:13pm

@matthewshaver matthewshaver requested review from JKarlavige and removed request for a team September 20, 2024 18:13
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address and removed Docs team Authored by the Docs team @dbt Labs labels Sep 20, 2024
Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :shipit: :shipit: :shipit:

@matthewshaver matthewshaver merged commit 2d674ae into current Sep 20, 2024
10 checks passed
@matthewshaver matthewshaver deleted the remove-warning branch September 20, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants