Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update metricflow-time-spine.md #6097

Merged
merged 14 commits into from
Sep 20, 2024
Merged

Update metricflow-time-spine.md #6097

merged 14 commits into from
Sep 20, 2024

Conversation

mirnawong1
Copy link
Contributor

adding metricflow time spine clarifications based on thread in slack

@mirnawong1 mirnawong1 requested a review from a team as a code owner September 19, 2024 10:56
@vercel Vercel
Copy link

vercel bot commented Sep 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 20, 2024 4:31pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Sep 19, 2024
nataliefiann
nataliefiann approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

An amazing PR - thanks for creating this! No suggestions or recommendations from me. I've approved this for you.

Kind Regards
Natalie

Jstein77
Jstein77 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Jstein77 Jstein77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mirnawong1 mirnawong1 merged commit 2392b45 into current Sep 20, 2024
6 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-28 branch September 20, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann approved these changes

@Jstein77 Jstein77 Jstein77 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirnawong1 @Jstein77 @nataliefiann