Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace angled single quotes with regular single quotes #6030

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

johnson-jay-l
Copy link
Contributor

What are you changing in this pull request and why?

Copy/paste required editing the ‘ and ’ characters (angled quotes) with ' (regular single quote). This causes churn when trying to get things working in the profiles.yml file using the example config.

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

Copy/paste required editing the ‘’ characters with ''
@johnson-jay-l johnson-jay-l requested review from dataders and a team as code owners September 6, 2024 18:33
Copy link

welcome bot commented Sep 6, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Sep 6, 2024

@johnson-jay-l is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the content Improvements or additions to content label Sep 6, 2024
@runleonarun runleonarun added the new contributor Label for first-time contributors label Sep 6, 2024
@github-actions github-actions bot added the size: x-small This change will take under 3 hours to fix. label Sep 6, 2024

### A third named compute, use whatever name you like
Compute2:
http_path: [‘/some/other/path’] # Required of each alternate compute
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are square brackets needed? There should be just a single http_path per compute entry, not a list, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right @johnson-jay-l ! the brackets were previously used to display code/fields that needed to be replaced with the user content. however, it can cause confusion for sure. I've removed them so it's clearer - thanks for flagging!

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Sep 9, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great catch @johnson-jay-l and thanks for contributing here! looking forward to future contributions ✨

@mirnawong1 mirnawong1 enabled auto-merge (squash) September 9, 2024 10:52
@mirnawong1 mirnawong1 disabled auto-merge September 9, 2024 10:52
@mirnawong1 mirnawong1 merged commit 8df69c7 into dbt-labs:current Sep 9, 2024
2 of 3 checks passed
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 9, 2024 10:55am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants