Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Behavior changes" #6019

Merged
merged 9 commits into from
Sep 5, 2024
Merged

Update "Behavior changes" #6019

merged 9 commits into from
Sep 5, 2024

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented Sep 5, 2024

What are you changing in this pull request and why?

  • Rename "Legacy behaviors" to "Behavior changes" — this is how we've been referring to them
  • Add definition of what we consider to be a behavior change, as well as examples of what does / doesn't constitute a behavior change

@jtcohen6 jtcohen6 requested a review from a team as a code owner September 5, 2024 11:40
@vercel Vercel
Copy link

vercel bot commented Sep 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 5, 2024 7:24pm

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Sep 5, 2024
jtcohen6
jtcohen6 commented Sep 5, 2024
View reviewed changes
website/docs/reference/global-configs/behavior-changes.md

> The same dbt project code and same dbt commands return one result before the behavior change, and they would return a different result after the behavior change.

Examples of behavior changes:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichelleArk Do these examples look reasonable & correct to you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes these are excellent!

@jtcohen6 jtcohen6 requested a review from MichelleArk September 5, 2024 11:49
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Sep 5, 2024
nataliefiann
nataliefiann reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @jtcohen6

Thanks for creating this PR - it's great! Other than a few punctuation amendments and one broken link (which I updated) I have no comments or suggestions. I haven't approved this yet as it looks like you're awaiting an additional review from some PMs. Please let me know if there's anything else I can do to help with this.

Kind Regards

@matthewshaver matthewshaver enabled auto-merge (squash) September 5, 2024 19:21
@matthewshaver matthewshaver merged commit 03507dd into current Sep 5, 2024
10 checks passed
@matthewshaver matthewshaver deleted the jerco/update-docs-behavior-changes branch September 5, 2024 19:24
@jtcohen6
Copy link
Collaborator Author

jtcohen6 commented Sep 6, 2024

Thanks everyone for the review & help getting this over the line! @MichelleArk @dbeatty10 @nataliefiann @matthewshaver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann left review comments

@matthewshaver matthewshaver matthewshaver approved these changes

@dbeatty10 dbeatty10 dbeatty10 approved these changes

@MichelleArk MichelleArk MichelleArk approved these changes

@graciegoheen graciegoheen Awaiting requested review from graciegoheen

Assignees
No one assigned
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jtcohen6 @MichelleArk @dbeatty10 @matthewshaver @nataliefiann @mirnawong1