Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing github login #6010

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Removing github login #6010

merged 10 commits into from
Sep 4, 2024

Conversation

matthewshaver
Copy link
Contributor

@matthewshaver matthewshaver commented Sep 4, 2024 •
edited
Loading

What are you changing in this pull request and why?

Removing GitHub login from dbt Cloud

  • Removed/edited content on the GitHub integration page
  • Edited links
  • Added a release note

Checklist

  • I have reviewed the Content style guide so my content adheres to these guidelines.
  • The topic I'm writing about is for specific dbt version(s) and I have versioned it according to the version a whole page and/or version a block of content guidelines.
  • I have added checklist item(s) to this list for anything anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."

@matthewshaver matthewshaver requested a review from a team as a code owner September 4, 2024 15:06
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 4, 2024 8:17pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Sep 4, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Sep 4, 2024
nghi-ly
nghi-ly reviewed Sep 4, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left several comments for ya. lemme know if you have any questions

website/docs/docs/cloud/git/connect-github.md Show resolved Hide resolved
website/docs/docs/cloud/git/connect-github.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/git/connect-github.md Outdated Show resolved Hide resolved
website/docs/docs/cloud/git/connect-github.md

## Limiting repository access in GitHub
If you are your GitHub organization owner, you can also configure the dbt Cloud GitHub application to have access to only select repositories. This configuration must be done in GitHub, but we provide an easy link in dbt Cloud to start this process.
<Lightbox src="/img/docs/dbt-cloud/cloud-configuring-dbt-cloud/connecting-github/configure-github.png" title="Configuring the dbt Cloud app"/>

## Personally authenticate with GitHub
## Authenticate your personal GitHub account
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ the new heading title, much better

website/docs/docs/dbt-versions/release-notes.md Outdated Show resolved Hide resolved
nghi-ly
nghi-ly approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@matthewshaver matthewshaver enabled auto-merge (squash) September 4, 2024 20:16
@matthewshaver matthewshaver merged commit 54fce19 into current Sep 4, 2024
9 of 10 checks passed
@matthewshaver matthewshaver deleted the github-login branch September 4, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghi-ly nghi-ly nghi-ly approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewshaver @nghi-ly