add file names for clarity #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr ass a `<File name="metricflow_time_spine.sql">` to the code examples or `<File name="models/model_name.yml">`
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
nataliefiann
reviewed
Sep 2, 2024
| @@ -83,6 +85,8 @@ and date_hour < dateadd(day, 30, current_timestamp()) | |||
|
|
|||
| <VersionBlock firstVersion="1.7"> | |||
|
|
|||
| <File name="metricflow_time_spine.sql"> | |||
|
|
|||
There was a problem hiding this comment.
Hiya @mirnawong1
I'm probably overthinking this but should the pic have two file names?
Kind Regards
Natalie
nataliefiann
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Thanks for creating this PR! I've left a question / non-blocking suggestion but otherwise it's good to go. I've approved this for you in the meantime.
Kind Regards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds a
<File name="metricflow_time_spine.sql">to the code examples or<File name="models/model_name.yml">