Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add versionblocks to cumulative metrics doc #5992

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr adds versionblocks (1.8 and lower, and 1.9+) to the cumulative metrics doc to differentiate the available parameters.

cumulative_type_params are only available in “versionless” for dbt-cloud users, which should be mentioned in the documentation.
If you’re a dbt-core user, not dbt-cloud, then you can still use the grain_to_date & window params, but nested under type_params instead of cumulative_type_params. The period_agg param is not available to dbt-core users yet.

raised in this internal slack thread and by user in dbt community: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1724944680040759

@mirnawong1 mirnawong1 requested a review from a team as a code owner August 29, 2024 15:51
Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 29, 2024 4:27pm

@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address Docs team Authored by the Docs team @dbt Labs labels Aug 29, 2024
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of notes inline, but otherwise looks great! Thank you!

website/docs/docs/build/cumulative-metrics.md Outdated Show resolved Hide resolved
website/docs/docs/build/cumulative-metrics.md Outdated Show resolved Hide resolved
@mirnawong1 mirnawong1 enabled auto-merge (squash) August 29, 2024 16:24
@mirnawong1 mirnawong1 merged commit 469025b into current Aug 29, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the add-versions-to-cumulative-metrics branch August 29, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants