Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description.md #5981

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Update description.md #5981

merged 2 commits into from
Aug 28, 2024

Conversation

mirnawong1
Copy link
Contributor

shared this document and realized there was no URL description to added it for clarification purposes.

slack thread

@mirnawong1 mirnawong1 requested a review from a team as a code owner August 28, 2024 09:44
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Aug 28, 2024 11:09am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Aug 28, 2024
@mirnawong1 mirnawong1 enabled auto-merge (squash) August 28, 2024 11:06
@@ -1,7 +1,7 @@
---
resource_types: all
datatype: markdown_string

description: "This guide explains how to use the description key to add YAML descriptions to dbt resources (models, sources, seeds) using markdown and Jinja for better documentation."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: "This guide explains how to use the description key to add YAML descriptions to dbt resources (models, sources, seeds) using markdown and Jinja for better documentation."
description: "This guide explains how to use the description key to add YAML descriptions to dbt resources (models, sources and, seeds) using markdown and Jinja for better documentation."

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for clarifying the description visibility question for me. I added a small non-blocker comment but otherwise the review is perfect with no suggestions or recommendations from me.

Kind Regards
Natalie

@mirnawong1 mirnawong1 merged commit 30525b1 into current Aug 28, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-27 branch August 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants