when columns removed for an incremental model #5978
Conversation
I found confusion line as it states "Similarly, if you remove a column from your incremental model, and execute a dbt run, this column will not be removed from your target table." But during the actual dbt run, it will encounter an error, though the documentation feels that dbt run should not fail. Link of the page https://docs.getdbt.com/docs/build/incremental-models#default-behavior
|
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
the
size: x-small
|
@nghi-ly is attempting to deploy a commit to the dbt-labs Team on Vercel. A member of the Team first needs to authorize it. |
|
thanks for opening this PR, @RatandeepSharma ! appreciate your contribution to the dbt Labs docs! @joellabes : i think it's ok to approve and merge this change but want to double-check with you first. do you agree? or have any suggestions? thanks! |
There was a problem hiding this comment.
I chatted with joel today for a technical review. I've reviewed your PR and left some minor feedback.
Thanks for catching this and letting us know, @RatandeepSharma !
Once you make the changes, we can ship it! ❇️
|
Hey @RatandeepSharma wanted to check in to see if you can make those changes my teammate suggested? |
Removed "and on older versions of dbt" in the sentence on line 215? This has been the default behavior for a while so is safe to remove.
|
Hey @mirnawong1 - I've implemented the changes as recommended. |
There was a problem hiding this comment.
thanks again for making those changes and opening up this pr @RatandeepSharma ! great job and merging for you ✨
What are you changing in this pull request and why?
If we remove a column from an incremental model and
on_schema_change: ignorethen execute dbt run, it results in an error. However, based on the documentation, it seems that dbt run should not fail in this scenario. I find this confusing.##Link of the page
https://docs.getdbt.com/docs/build/incremental-models#default-behavior