Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General examples of calling a macro in a hook #5972

Merged
merged 6 commits into from
Sep 5, 2024
Merged

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Aug 23, 2024

Preview: Calling a macro in a hook

Preview: pre-hook & post-hook

What are you changing in this pull request and why?

We have a couple concrete examples of calling a macro in a hook (like here and here). But we don't currently have any co-located canonical examples of the different locations where hooks can be configured:

  1. SQL model config
  2. properties.yml *
  3. dbt_project.yml

* Calling a macro in a hook within a properties YAML file was fixed in v1.8+ by dbt-labs/dbt-core#10603.

Other pages to review

Once dbt-labs/dbt-core#7128 is resolved, we should also review these pages to ensure they include examples of configs across dbt_project YAML files, properties YAML files, and node-level config in SQL files:

Additional context

Inspired by dbt-labs/dbt-core#10522

Checklist

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Sep 5, 2024 10:00am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Aug 23, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review August 23, 2024 23:44
@dbeatty10 dbeatty10 requested a review from a team as a code owner August 23, 2024 23:44
@dbeatty10 dbeatty10 marked this pull request as draft August 25, 2024 03:31
@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Sep 4, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mirnawong1 mirnawong1 enabled auto-merge (squash) September 5, 2024 09:59
@mirnawong1 mirnawong1 merged commit a451264 into current Sep 5, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-2 branch September 5, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants