Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github-permissions.md #5860

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Update github-permissions.md #5860

merged 12 commits into from
Jul 30, 2024

Conversation

wusanny
Copy link
Contributor

@wusanny wusanny commented Jul 30, 2024

What are you changing in this pull request and why?

Existing documentation on how to accept/update new Github app permission is lacking the visualisation for confused customers (me included!) to find exactly where the Settings are and what they should see under Applications.

I managed to navigate to the right spot, but I was not sure where should I be seeing this 'accept permissions' and if I can even see it. I also noticed a few customers checking their repository settings instead of their account settings.

Hoping the images and clarification on steps will provide a clearer understanding for the customers.

Checklist

@wusanny wusanny requested a review from a team as a code owner July 30, 2024 06:05
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 30, 2024 9:49am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jul 30, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @wusanny , great pr and thank you for adding the images to make this clearer! really appreciate your time here! I've adjusted the images so they follow our style guide format.

will approve and merge this for you! let me know if you have any questions!

@mirnawong1 mirnawong1 enabled auto-merge (squash) July 30, 2024 09:42
@mirnawong1 mirnawong1 merged commit ca2605f into current Jul 30, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the wusanny-patch-1 branch July 30, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants