Clarify that tests is backwards compatible to data_tests #5859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
|
Thank you @joellabes! I totally agree. I think we should also:
|
graciegoheen
added
the
priority: high
runleonarun
approved these changes
Aug 1, 2024
| @@ -306,6 +304,8 @@ data_tests: | |||
|
|
|||
| </File> | |||
|
|
|||
| To suppress warnings about the rename, add `TestsConfigDeprecation` to the `silence` block of the `warn_error_options` flag in `dbt_project.yml`, [as described in the Warnings documentation](https://docs.getdbt.com/reference/global-configs/warnings). | |||
There was a problem hiding this comment.
We can change this warning name once this issue is addressed dbt-labs/dbt-core#10504
There was a problem hiding this comment.
I checked here, and the TestConfigDeprecation name itself won't change, just the warning message it returns. (Because changing that name would itself be a breaking change!)
Co-authored-by: Leona B. Campbell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
In this Slack thread, someone pointed out to me that we're indicating that backwards compatibility for
testscould be removed at some point in the future.We have no plans to do so, and even if we did decide to do it one day it would go through the behaviour change process, so we don't need to be warning about urgent action or disruption.
Checklist