Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rendering of snippet for run results JSON file #5816

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jul 20, 2024

Preview

What are you changing in this pull request and why?

It currently looks like this:

image

When it should look more like this:

image

Note

There is an extra newline between bullet points due to the snippet, but I wasn't able to make it go away after a couple attempts.

If we want to eliminate the extra newline, we'd either need to go away from using a snippet or figure out how to make the snippet place nice.

Checklist

Copy link

vercel bot commented Jul 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Jul 23, 2024 9:22am

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jul 20, 2024
@dbeatty10 dbeatty10 marked this pull request as ready for review July 20, 2024 01:09
@dbeatty10 dbeatty10 requested a review from a team as a code owner July 20, 2024 01:09
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wow, great catch and thanks for always improving our docs @dbeatty10 ! merging this for you!

@mirnawong1 mirnawong1 enabled auto-merge (squash) July 23, 2024 09:17
@mirnawong1 mirnawong1 merged commit 9c50749 into current Jul 23, 2024
10 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty10-patch-2-1 branch July 23, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants