update measures doc #5737
Merged
update measures doc #5737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
github-actions
bot
added
size: small
jordan's feedback
github-actions
bot
added
size: medium
mirnawong1
commented
Jul 10, 2024
| Since this is a foreign-to-primary relationship, a left join is implemented where the `transactions` semantic model joins the `user_signup` semantic model since the `average_purchase_price` measure is defined in the `transactions` semantic model. | ||
| - MetricFlow uses`user_id` as the join key to link two semantic models, `transactions` and `user_signup`. This enables you to query the `average_purchase_price` metric in `transactions`, grouped by the `type` dimension in the `user_signup` semantic model. | ||
| - Note that the `average_purchase_price` measure is defined in the `transactions` semantic model, where `user_id` is a foreign entity. However, the `user_signup` semantic model has `user_id` as a primary entity. | ||
| - Since this is a foreign-to-primary relationship, a left join is performed where the `transactions` semantic model joins the `user_signup` semantic model since the `average_purchase_price` measure is defined in the `transactions` semantic model. |
There was a problem hiding this comment.
Hiya @mirnawong1
The doc is great and there are no real changes or suggestions I have. The only thing I thought was maybe rewording this sentence "Since this is a foreign-to-primary relationship, a left join is performed where the transactions semantic model joins the user_signup semantic model since the average_purchase_price measure is defined in the transactions semantic model." as SL is ref'd 3 times.
Kind Regards
nataliefiann
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Hiya @mirnawong1
Other than the one comment I left, the PR is great and I've approved this for you. Please let me know if there's anything I can do to help with this.
Kind Regards
mirnawong1
commented
Jul 12, 2024
mirnawong1
commented
Jul 12, 2024
mirnawong1
commented
Jul 12, 2024
mirnawong1
commented
Jul 12, 2024
mirnawong1
commented
Jul 12, 2024
| Since this is a foreign-to-primary relationship, a left join is implemented where the `transactions` semantic model joins the `user_signup` semantic model since the `average_purchase_price` measure is defined in the `transactions` semantic model. | ||
| - MetricFlow uses `user_id` as the join key to link two semantic models, `transactions` and `user_signup`. This allows you to query the `average_purchase_price` metric in the `transactions` semantic model, grouped by the `type` dimension in the `user_signup` semantic model. | ||
| - Note that the `average_purchase_price` measure is defined in `transactions`, where `user_id` is a foreign entity. However, `user_signup` has `user_id` as a primary entity. | ||
| - Since `user_id` is a foreign key in `transactions` and a primary key in `user_signup`, MetricFlow performs a left join where `transactions` joins `user_signup` to access the `average_purchase_price` measure defined in `transactions`. |
There was a problem hiding this comment.
thanks @nataliefiann ! updated/reworded this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates some yaml code exmaples in the measure doc. raised by Zach in dbt community slack: https://getdbt.slack.com/archives/C02CCBBBR1D/p1719959209705599
Outstanding question raised to SL team: