Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nodes to project state doc #5654

Merged
merged 28 commits into from
Jul 10, 2024
Merged

add nodes to project state doc #5654

merged 28 commits into from
Jul 10, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr continue's @dbeatty10 's pr and adds Analysis Saved query, and Unit tests to the nodes table.

Resolves #5648

mirnawong1 and others added 19 commits June 11, 2024 10:15
this pr adds a 'interact w dbt cloud features' section (or new page) to explorer. it sets to give users clear info on how/where  they can access explorer from diff dbt cloud product/feature areas.
this pr continue's @dbeatty10 's [pr](#5641) and adds Analysis
Saved query, and Unit tests to the nodes table.

Resolves #5648
@mirnawong1 mirnawong1 requested a review from a team as a code owner June 13, 2024 10:39
Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 9:55am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Jun 13, 2024
@mirnawong1 mirnawong1 enabled auto-merge (squash) June 18, 2024 10:05
@mirnawong1
Copy link
Contributor Author

hey @dbeatty10 , thanks so much for your review! I've tweaked this to remove saved queries as eng confirmed it's not available in the disco api. whenever you have a chance, can you re-review? thankyou!

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1
I've had a look at the PR for you and it's great! The links work perfectly. I left a small note (but I think I may be reading it wrong, too deeply...)

Kind Regards

@mirnawong1 mirnawong1 enabled auto-merge (squash) July 10, 2024 09:50
@mirnawong1 mirnawong1 merged commit 4197c55 into current Jul 10, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-26 branch July 10, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add node/resource types to project state doc
3 participants