Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table aliases needed to unit test joins #5460

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented May 7, 2024

What are you changing in this pull request and why?

To unit test join logic, need to use table aliases.

closes #5418

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner May 7, 2024 18:28
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 7, 2024 6:59pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels May 7, 2024
@nghi-ly nghi-ly enabled auto-merge May 7, 2024 18:52
@nghi-ly nghi-ly merged commit c114420 into current May 7, 2024
10 of 11 checks passed
@nghi-ly nghi-ly deleted the ly-docs-issue-5418 branch May 7, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unit testing known exception - can't unit test join logic that doesn't have aliases
2 participants