Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add example to redshift grants section #5156

Closed
wants to merge 14 commits into from
Closed

add example to redshift grants section #5156

wants to merge 14 commits into from

Conversation

mirnawong1
Copy link
Contributor

@mirnawong1 mirnawong1 commented Mar 25, 2024 •
edited
Loading

raised in the slack communit, this PR sets to add info that grants roles/groups is supported for redshift.

raised in internal slack and also used discourse as sourc.e

@mirnawong1 mirnawong1 requested a review from a team as a code owner March 25, 2024 11:01
@vercel Vercel
Copy link

vercel bot commented Mar 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 1:38pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Mar 25, 2024
@b-per
Copy link
Contributor

b-per commented Mar 25, 2024

I am not the expert here, but based on my quick testing I don't think that this is 100% correct.

My understanding is that

  • for users we support the + syntax for grants, and in that case, we just need to list the users, e.g. select: ["bper"]
  • for roles and groups
    • we don't support the + for grants, so we always need to provide the full list of roles/groups that need acess
    • and we have to prefix the role/group by role or group, e.g. select: ["role my_role", "group my_group"]

@mirnawong1 mirnawong1 marked this pull request as draft March 25, 2024 14:47
matthewshaver
matthewshaver reviewed Mar 27, 2024
View reviewed changes
website/docs/reference/resource-configs/grants.md Outdated
@@ -249,7 +249,20 @@ models:

<div warehouse="Redshift">

* Granting to / revoking from is only fully supported for Redshift users (not groups or roles).
For Redshift, you need to explicitly grant roles and groups access to your models, whether to single users, groups, or roles, and you can revoke access as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better suited here with a link from the note https://docs.getdbt.com/reference/resource-configs/redshift-configs or maybe at least also there?

@mirnawong1
Update grants.md
ec47ec3 
benoit's feedback
@mirnawong1 mirnawong1 marked this pull request as ready for review April 12, 2024 09:11
dataders
dataders requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only one small change!

website/docs/reference/resource-configs/grants.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor Author

thanks so much @dataders ! i think I've folded in all your suggestions now 🙏

mirnawong1
mirnawong1 commented May 2, 2024
View reviewed changes
website/docs/reference/resource-configs/grants.md
schema: my_schema
description: "My schema"
+grants:
select: ["gspider"] # example of user access
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👻 🕷️ 🕸️

dataders
dataders approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@dataders dataders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! let's merge this! though as a reminder, dbt-labs/dbt-redshift#626
will be worked on in the next month which will require another pass at this page. Hopefully though, the result is the docs become simpler with less caveats

@mirnawong1
Copy link
Contributor Author

as discussed in slack thread](https://dbt-labs.slack.com/archives/C03SK9W08BC/p1714506360050039), closing this pr as this is not the intended behavior. see dbt-labs/dbt-redshift#415 for more info.

@mirnawong1 mirnawong1 closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewshaver matthewshaver matthewshaver left review comments

@dataders dataders dataders approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirnawong1 @b-per @dataders @matthewshaver