Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify bq qs step after config block change #4932

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Conversation

mirnawong1
Copy link
Contributor

this pr updates the quickstart snippet (for bigquery specifically) per user feedback here. dbt run isn't needed after adding a model config block for materialization. instead, users shoudl run dbt run --full-refresh for the change to take place.

@mirnawong1 mirnawong1 requested a review from a team as a code owner February 15, 2024 17:44
Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2024 6:58pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Feb 15, 2024
@mirnawong1 mirnawong1 changed the title remove dbt run after config change. clarify bq qs step after config block change Feb 15, 2024
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirnawong1 some small clarifications.

An aside, do you think this might feel out-of-place in other warehouse guides? I think there's no elegant way to add it in just the BQ guide, so I'm not sure there's a better suggestion.

@mirnawong1
Copy link
Contributor Author

@mirnawong1 some small clarifications.

An aside, do you think this might feel out-of-place in other warehouse guides? I think there's no elegant way to add it in just the BQ guide, so I'm not sure there's a better suggestion.

thank you @mirnawong1 ! i do too, but also had a hard time adding it without messing up the snippet. if i add it before, it's too early. if i add it after, it might be missed. that's why i asked whether step 4 was necessary. unless i just remove the snippet for bq?

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mirnawong1 let's go with this and see if people comment about it. The benefits of a snippet is way higher than it being out of place. Let's use this.

Approved!

@mirnawong1
Copy link
Contributor Author

lol i commented to myself 🙈

thanks @runleonarun !

@mirnawong1 mirnawong1 enabled auto-merge February 15, 2024 18:50
@mirnawong1 mirnawong1 merged commit efb8e05 into current Feb 15, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the update/bq-guide branch February 15, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants