-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify bq qs step after config block change #4932
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirnawong1 some small clarifications.
An aside, do you think this might feel out-of-place in other warehouse guides? I think there's no elegant way to add it in just the BQ guide, so I'm not sure there's a better suggestion.
Co-authored-by: Leona B. Campbell <[email protected]>
Co-authored-by: Leona B. Campbell <[email protected]>
thank you @mirnawong1 ! i do too, but also had a hard time adding it without messing up the snippet. if i add it before, it's too early. if i add it after, it might be missed. that's why i asked whether step 4 was necessary. unless i just remove the snippet for bq? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mirnawong1 let's go with this and see if people comment about it. The benefits of a snippet is way higher than it being out of place. Let's use this.
Approved!
lol i commented to myself 🙈 thanks @runleonarun ! |
this pr updates the quickstart snippet (for bigquery specifically) per user feedback here. dbt run isn't needed after adding a model config block for materialization. instead, users shoudl run dbt run --full-refresh for the change to take place.