adds sl course link and updates fill_nulls_with and join_to_timespine #4912

mirnawong1 · 2024-02-14T11:54:52Z

This PR does the following:

adds links to the newly launched SL video courses in various places for visual learning
Updates info related to fill_nulls_width and join_to_timespine in various pages: simple and cumulative metrics page. adds join_to_timespine to all metrics pages, and removes fill_nulls_with in ration and derived metrics page. (see linear for more details)

this PR also turns the about metricflow faqs into detailsToggle component.

vercel · 2024-02-14T11:54:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-getdbt-com	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 21, 2024 5:09pm

mirnawong1 · 2024-02-14T11:58:12Z

website/docs/docs/build/conversion-metrics.md

@@ -33,6 +33,7 @@ The specification for conversion metrics is as follows:
 | `base_property` | The property from the base semantic model that you want to hold constant.  | Entity or Dimension | Optional |
 | `conversion_property` | The property from the conversion semantic model that you want to hold constant.  | Entity or Dimension | Optional |
 | `fill_nulls_with` | Set the value in your metric definition instead of null (such as zero). | String | Optional |
+| `join_to_timespine` | Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. | Optional |


added to the parameters table

mirnawong1 · 2024-02-14T11:58:28Z

website/docs/docs/build/cumulative-metrics.md

@@ -21,6 +21,7 @@ This metric is common for calculating things like weekly active users, or month-
 | `window` | The accumulation window, such as 1 month, 7 days, 1 year. This can't be used with `grain_to_date`. | Optional  |
 | `grain_to_date` | Sets the accumulation grain, such as month will accumulate data for one month. Then restart at the beginning of the next. This can't be used with `window`. | Optional |
 | `fill_nulls_with` | Set the value in your metric definition instead of null (such as zero).| Optional |
+| `join_to_timespine` | Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. | Optional |


added to the parameters table

website/docs/docs/build/cumulative-metrics.md

mirnawong1 · 2024-02-14T11:59:23Z

website/docs/docs/build/derived-metrics.md

 | `offset_window` | Set the period for the offset window, such as 1 month. This will return the value of the metric one month from the metric time.  | Optional |
+| `join_to_timespine` | Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. | Optional |


should i have added to the parameters table? sounds like it's not supported right?

website/docs/docs/build/metrics-overview.md

mirnawong1 · 2024-02-14T11:59:54Z

website/docs/docs/build/metrics-overview.md

-        - distinct_users
-    # Omitting window will accumulate the measure over all time
-      window: 7 days
+      measure:


changed to measure not measures

mirnawong1 · 2024-02-14T12:00:10Z

website/docs/docs/build/ratio-metrics.md

@@ -21,7 +21,7 @@ Ratio allows you to create a ratio between two metrics. You simply specify a num
 | `denominator` |  The name of the metric used for the denominator, or structure of properties. | Required  |
 | `filter` | Optional filter for the numerator or denominator. | Optional |
 | `alias` | Optional alias for the numerator or denominator. | Optional |
-| `fill_nulls_with` | Set the value in your metric definition instead of null (such as zero). | Optional |
+| `join_to_timespine` | Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. | Optional |


added to the parameters table - but should i remove?

mirnawong1 · 2024-02-14T12:00:18Z

website/docs/docs/build/simple.md

@@ -20,10 +20,10 @@ Simple metrics are metrics that directly reference a single measure, without any
 | `type_params` | The type parameters of the metric. | Required |
 | `measure` | The measure you're referencing. | Required |
 | `fill_nulls_with` | Set the value in your metric definition instead of null (such as zero). | Optional |
+| `join_to_timespine` | Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. | Optional |


added to the parameters table

mirnawong1 · 2024-02-14T15:07:34Z

cc @MichelleBaird-DBT - this pr adds the course video links to the SL docs

website/docs/docs/build/metrics-overview.md

Jstein77

Found two places where the metric spec is incorrect. After those are fixed this should be good to go!

mirnawong1 · 2024-02-21T12:13:42Z

website/docs/docs/build/conversion-metrics.md

@@ -93,7 +103,7 @@ Next, define a conversion metric as follows:
  type: conversion
  label: Visit to Buy Conversion Rate (7-day window)
  type_params:
-    fills_nulls_with: 0
+    fill_nulls_with: 0


the nesting doesn't match the example so updated to this:

- name: visit_to_buy_conversion_rate_7d description: "Conversion rate from visiting to transaction in 7 days" type: conversion label: Visit to Buy Conversion Rate (7-day window) type_params: conversion_type_params: base_measure: visits name: visits fill_nulls_with: 0 conversion_measure: sellers name: sellers entity: user window: 7 days

previously, it was this:

- name: visit_to_buy_conversion_rate_7d description: "Conversion rate from visiting to transaction in 7 days" type: conversion label: Visit to Buy Conversion Rate (7-day window) type_params: fill_nulls_with: 0 conversion_type_params: base_measure: visits conversion_measure: sellers entity: user window: 7 days

mirnawong1 added 2 commits February 13, 2024 16:18

snippet and linear tasks

2f28e2a

updates

1c26f53

mirnawong1 requested a review from a team as a code owner February 14, 2024 11:54

github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Feb 14, 2024

mirnawong1 added 2 commits February 14, 2024 11:56

Merge branch 'current' into add-sl-course-update-fills_nulls_width

69e66b8

Update gsheets.md

a145179

mirnawong1 commented Feb 14, 2024

View reviewed changes

website/docs/docs/build/cumulative-metrics.md Show resolved Hide resolved

mirnawong1 commented Feb 14, 2024

View reviewed changes

website/docs/docs/build/metrics-overview.md Outdated Show resolved Hide resolved

mirnawong1 commented Feb 14, 2024

View reviewed changes

Update simple.md

673c3d4

vercel bot deployed to Preview February 14, 2024 12:13 View deployment

mirnawong1 requested review from courtneyholcomb, Jstein77 and MichelleBaird-DBT February 14, 2024 15:07

Merge branch 'current' into add-sl-course-update-fills_nulls_width

5b365ba

mirnawong1 added the auto update label Feb 15, 2024

vercel bot deployed to Preview February 15, 2024 10:47 View deployment

This branch was auto-updated!

c0e3fa7

vercel bot deployed to Preview February 15, 2024 12:02 View deployment

This branch was auto-updated!

3273da0

This branch was auto-updated!

372ba3d

vercel bot deployed to Preview February 20, 2024 14:20 View deployment

This branch was auto-updated!

662a175

vercel bot deployed to Preview February 20, 2024 15:09 View deployment

This branch was auto-updated!

f83a7c8

vercel bot deployed to Preview February 20, 2024 17:43 View deployment

This branch was auto-updated!

e7a73b4

vercel bot deployed to Preview February 20, 2024 18:35 View deployment

Jstein77 reviewed Feb 20, 2024

View reviewed changes

website/docs/docs/build/metrics-overview.md Outdated Show resolved Hide resolved

Jstein77 approved these changes Feb 20, 2024

View reviewed changes

This branch was auto-updated!

119bff6

vercel bot deployed to Preview February 21, 2024 06:33 View deployment

This branch was auto-updated!

e6ea2b7

vercel bot deployed to Preview February 21, 2024 11:27 View deployment

This branch was auto-updated!

334fc71

vercel bot deployed to Preview February 21, 2024 11:47 View deployment

mirnawong1 commented Feb 21, 2024

View reviewed changes

mirnawong1 and others added 7 commits February 21, 2024 12:21

fix spec

daa67b2

fix table

af64fb2

Update cumulative-metrics.md

9d398d4

Update metrics-overview.md

e1fd607

Update ratio-metrics.md

6c82606

Update semantic-models.md

8018b23

Update semantic-models.md

5edce49

vercel bot deployed to Preview February 21, 2024 12:43 View deployment

Update conversion-metrics.md

a942f8b

vercel bot deployed to Preview February 21, 2024 17:09 View deployment

mirnawong1 merged commit 23c8c87 into current Feb 21, 2024
7 checks passed

mirnawong1 deleted the add-sl-course-update-fills_nulls_width branch February 21, 2024 17:20

runleonarun added the February-2024 label Mar 22, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adds sl course link and updates fill_nulls_with and join_to_timespine #4912

adds sl course link and updates fill_nulls_with and join_to_timespine #4912

mirnawong1 commented Feb 14, 2024

vercel bot commented Feb 14, 2024 •

edited

Loading

mirnawong1 Feb 14, 2024

mirnawong1 Feb 14, 2024

mirnawong1 Feb 14, 2024

mirnawong1 Feb 14, 2024

mirnawong1 Feb 14, 2024

mirnawong1 Feb 14, 2024

mirnawong1 commented Feb 14, 2024

Jstein77 left a comment

mirnawong1 Feb 21, 2024 •

edited

Loading

		\| `offset_window` \| Set the period for the offset window, such as 1 month. This will return the value of the metric one month from the metric time. \| Optional \|
		\| `join_to_timespine` \| Boolean that indicates if the aggregated measure should be joined to the time spine table to fill in missing dates. Default `false`. \| Optional \|

adds sl course link and updates fill_nulls_with and join_to_timespine #4912

adds sl course link and updates fill_nulls_with and join_to_timespine #4912

Conversation

mirnawong1 commented Feb 14, 2024

vercel bot commented Feb 14, 2024 • edited Loading

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 Feb 14, 2024

Choose a reason for hiding this comment

mirnawong1 commented Feb 14, 2024

Jstein77 left a comment

Choose a reason for hiding this comment

mirnawong1 Feb 21, 2024 • edited Loading

Choose a reason for hiding this comment

vercel bot commented Feb 14, 2024 •

edited

Loading

mirnawong1 Feb 21, 2024 •

edited

Loading