Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to group_by #4899

Merged
merged 17 commits into from
Feb 14, 2024
Merged

update to group_by #4899

merged 17 commits into from
Feb 14, 2024

Conversation

mirnawong1
Copy link
Contributor

this pr updates the the exports code example to 'group_by' and not 'group_bys'. it also update the saved queries parameter too. reported by Steve Dowling here: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1707782794575719

this pr updates the the exports code example to 'group_by' and not 'group_bys'. it also update the saved queries parameter too.
@mirnawong1 mirnawong1 requested a review from a team as a code owner February 13, 2024 09:08
Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 14, 2024 4:21pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Feb 13, 2024
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Feb 13, 2024
@mirnawong1 mirnawong1 enabled auto-merge February 13, 2024 09:29
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left one sugg

website/docs/docs/use-dbt-semantic-layer/exports.md Outdated Show resolved Hide resolved
@mirnawong1
Copy link
Contributor Author

hey @nghi-ly ! thanks can you rereview pls

@mirnawong1 mirnawong1 merged commit 3b4da75 into current Feb 14, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-12 branch February 14, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants