-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update to group_by #4899
Merged
Merged
update to group_by #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr updates the the exports code example to 'group_by' and not 'group_bys'. it also update the saved queries parameter too.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
Improvements or additions to content
size: x-small
This change will take under 3 hours to fix.
Docs team
Authored by the Docs team @dbt Labs
labels
Feb 13, 2024
github-actions
bot
added
size: small
This change will take 1 to 2 days to address
and removed
size: x-small
This change will take under 3 hours to fix.
labels
Feb 13, 2024
mirnawong1
commented
Feb 13, 2024
mirnawong1
commented
Feb 13, 2024
nghi-ly
reviewed
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! left one sugg
Co-authored-by: Ly Nguyen <[email protected]>
hey @nghi-ly ! thanks can you rereview pls |
nghi-ly
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto update
content
Improvements or additions to content
Docs team
Authored by the Docs team @dbt Labs
February-2024
size: small
This change will take 1 to 2 days to address
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr updates the the exports code example to 'group_by' and not 'group_bys'. it also update the saved queries parameter too. reported by Steve Dowling here: https://dbt-labs.slack.com/archives/C02NCQ9483C/p1707782794575719