Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data-tests.md. Solving double negative. #4891

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

ialdg
Copy link
Contributor

@ialdg ialdg commented Feb 11, 2024

Hi.
Since the tests looks for negative amount records, why not say so instead of using a double negative, which is not the easiest to read and involves longer code? Regards.
IL.

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

Hi.
Since the tests looks for negative amount records, why not say so instead of using a double negative, which is not the easiest to read and involves longer code?
Regards.
IL.
@ialdg ialdg requested a review from a team as a code owner February 11, 2024 06:05
Copy link

welcome bot commented Feb 11, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2024 4:40pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Feb 11, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Feb 11, 2024
@matthewshaver
Copy link
Contributor

Thank you @ialdg Made another edit to add clarity to the whole section and will merge this.

@matthewshaver matthewshaver merged commit 546b6f2 into dbt-labs:current Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content February-2024 new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants