Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metricflow-commands.md #4877

Merged
merged 5 commits into from
Feb 9, 2024
Merged

Update metricflow-commands.md #4877

merged 5 commits into from
Feb 9, 2024

Conversation

mirnawong1
Copy link
Contributor

add dbt list saved queries command and --show-exports flag per recent eng update: https://linear.app/dbt-labs/issue/SL-1655/cloud-cli-list-exports-in-dbt-sl-list-saved-queries#comment-aae9ef8f

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@mirnawong1 mirnawong1 requested a review from a team as a code owner February 8, 2024 20:39
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 9, 2024 4:22pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: small This change will take 1 to 2 days to address labels Feb 8, 2024
Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few recommended changes, otherwise looks good!

**Output**

```bash
[*main}[~/git/jaffle-sl-template]$ ../dbti/dbt sl list saved-queries --show-exports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets get rid of most of this and just leave

dbt sl list saved-queries --show-exports


```bash
[*main}[~/git/jaffle-sl-template]$ ../dbti/dbt sl list saved-queries --show-exports
WARNING: version 0.35.23 of the dbt Cloud CLI is now available. During beta, old versions are not supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Comment on lines 201 to 203
- Export(name_customer_orders, exportAS=TABLE)
- Export(name_customer_orderss, exportAS=VIEW)
- Export(name_customer_ordersss, alias=test, schemas=lfg, exportAS=TABLE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change the namings here, maybe

- Export(new_customer_orders_table, exportAs=TABLE)
- Export(new_customer_orders_view, exportAs=VIEW)
- Export(new_customer_orders, alias=orders, schemas=customer_schema, exportAs=TABLE)

fold will's feedback
@mirnawong1
Copy link
Contributor Author

thanks soo much @WilliamDee ! i've folded in your changes and i hope it's ok!

Copy link
Contributor

@WilliamDee WilliamDee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!! 🙏

@mirnawong1 mirnawong1 enabled auto-merge February 9, 2024 16:15
@mirnawong1 mirnawong1 merged commit 5c21d65 into current Feb 9, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-12 branch February 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants