Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timezone parameters order for convert_timezone function in docs #4860

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

k-ebu
Copy link
Contributor

@k-ebu k-ebu commented Feb 6, 2024

What are you changing in this pull request and why?

I am correcting the order of time zones specified for the convert_timezone function in the dbt documentation.
The current documentation incorrectly lists the source timezone as 'UTC' and the target timezone as 'Australia/Sydney' when it should be the other way around.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@k-ebu k-ebu requested a review from a team as a code owner February 6, 2024 06:39
Copy link

welcome bot commented Feb 6, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Feb 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 8, 2024 5:35pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Feb 6, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Feb 6, 2024
@k-ebu k-ebu changed the title docs: fix param docs: fix convert_timezone function Feb 6, 2024
@k-ebu k-ebu changed the title docs: fix convert_timezone function Fix incorrect timezone parameters order for convert_timezone function in docs Feb 6, 2024
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much for opening this PR and for your contributions to the dbt docs, @k-ebu ! let's :shipit:

@nghi-ly nghi-ly merged commit d71ea15 into dbt-labs:current Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants