Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate log_format in profiles.yml.md #4845

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

nicholasyager
Copy link
Contributor

@nicholasyager nicholasyager commented Feb 1, 2024

What are you changing in this pull request and why?

As mentioned on Slack, the log_format option appears twice in the code block in profiles.yml.md. This PR removes one of the duplicate entries.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

The `log_format` property for profiles.yml.md appears twice in the provided documentation.
Copy link

welcome bot commented Feb 1, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 2:51pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Feb 1, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Feb 1, 2024
@@ -33,7 +33,6 @@ This section identifies the parts of your `profiles.yml` that aren't specific to
[static_parser](/reference/global-configs/parsing): <true | false>
[cache_selected_only](/reference/global-configs/cache): <true | false>
[printer_width](/reference/global-configs/print-output#printer-width): <integer>
[log_format](/reference/global-configs/logs): <text | json | default>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see line 28 for the first instance of log_format in this yml code block.

@nicholasyager nicholasyager marked this pull request as ready for review February 1, 2024 14:50
@nicholasyager nicholasyager requested a review from a team as a code owner February 1, 2024 14:50
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nicholasyager oh great catch and thank you for opening this pr up to fix this up! really appreciate it and will get this merged for you to avoid confusion ✨

@mirnawong1 mirnawong1 enabled auto-merge February 1, 2024 14:52
@mirnawong1 mirnawong1 disabled auto-merge February 1, 2024 14:59
@mirnawong1 mirnawong1 merged commit 8e1ed1c into dbt-labs:current Feb 1, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content February-2024 new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants