-
Notifications
You must be signed in to change notification settings - Fork 977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update using-jinja.md #4843
Update using-jinja.md #4843
Conversation
Updated the get_payment_methods macro call
Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨ |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hey @aruness , thanks for opening this pr up and great first contribution! i'd love to understand more on why you think we should add would love to hear your thoughts on this! |
Oh, I get it, closing this PR. I apologize for my oversight.
…________________________________
From: mirnawong1 ***@***.***>
Sent: Thursday, February 1, 2024 5:24 PM
To: dbt-labs/docs.getdbt.com ***@***.***>
Cc: Arun Mohanty ***@***.***>; Mention ***@***.***>
Subject: Re: [dbt-labs/docs.getdbt.com] Update using-jinja.md (PR #4843)
hey @aruness<https://github.com/aruness> , thanks for opening this pr up and great first contribution! i'd love to understand more on why you think we should add (column_name, relation) %} to the macro? from my understanding, the {% macro get_payment_methods() %} example is correct since it's meant to fetch payment methods from a particular relation using the get_column_values macro.
would love to hear your thoughts on this!
—
Reply to this email directly, view it on GitHub<#4843 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A2EVLTINOD2JQ7HFMPF6UUDYRN66TAVCNFSM6AAAAABCUNTD76VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMRRGE2TMMJVGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Closed, seems like an oversight from my end. |
no worries! thanks for opening this pr up and let us know if you have any questions! |
Updated the get_payment_methods macro call
What are you changing in this pull request and why?
Checklist
Adding or removing pages (delete if not applicable):
website/sidebars.js
website/static/_redirects
npm run build
to update the links that point to deleted pages