Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update using-jinja.md #4843

Closed
wants to merge 1 commit into from
Closed

Update using-jinja.md #4843

wants to merge 1 commit into from

Conversation

aruness
Copy link

@aruness aruness commented Feb 1, 2024

Updated the get_payment_methods macro call

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

Updated the get_payment_methods macro call
@aruness aruness requested a review from a team as a code owner February 1, 2024 08:08
Copy link

welcome bot commented Feb 1, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Feb 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 1, 2024 8:14am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Feb 1, 2024
@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. labels Feb 1, 2024
@mirnawong1
Copy link
Contributor

hey @aruness , thanks for opening this pr up and great first contribution! i'd love to understand more on why you think we should add (column_name, relation) %} to the macro? from my understanding, the {% macro get_payment_methods() %} example is correct since it's meant to fetch payment methods from a particular relation using the get_column_values macro.

would love to hear your thoughts on this!

@aruness
Copy link
Author

aruness commented Feb 1, 2024 via email

@aruness aruness closed this Feb 1, 2024
@aruness aruness deleted the patch-1 branch February 1, 2024 16:11
@aruness
Copy link
Author

aruness commented Feb 1, 2024

Closed, seems like an oversight from my end.

@mirnawong1
Copy link
Contributor

no worries! thanks for opening this pr up and let us know if you have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content guides Knowledge best suited for Guides new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants