Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add new dynamic table paramaters #4835

Closed

Conversation

HenkvanDyk
Copy link

@HenkvanDyk HenkvanDyk commented Jan 31, 2024

What are you changing in this pull request and why?

Documentation for features added here dbt-labs/dbt-snowflake#893

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@HenkvanDyk HenkvanDyk requested review from dataders and a team as code owners January 31, 2024 10:11
Copy link

welcome bot commented Jan 31, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 10:16am

@HenkvanDyk HenkvanDyk marked this pull request as draft January 31, 2024 10:11
@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 31, 2024
@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address and removed new contributor Label for first-time contributors labels Jan 31, 2024
Copy link

vercel bot commented Jul 30, 2024

@matthewshaver is attempting to deploy a commit to the dbt-labs Team on Vercel.

A member of the Team first needs to authorize it.

@matthewshaver
Copy link
Contributor

@HenkvanDyk and @dataders what is the status of this draft? Should we move forward here?

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @matthewshaver I noticed they have a new PR for this work. Removing comment per pr#1081

@@ -360,6 +360,10 @@ Dynamic tables are supported with the following configuration parameters:
| [`on_configuration_change`](/reference/resource-configs/on_configuration_change) | `<string>` | no | `apply` | n/a |
| [`target_lag`](#target-lag) | `<string>` | yes | | alter |
| [`snowflake_warehouse`](#configuring-virtual-warehouses) | `<string>` | yes | | alter |
| [`refresh_mode`](#refresh-mode) | `<string>` | no | | n/a |
| [`initialize`](#initialize) | `<string>` | no | | n/a |
| [`comment`](#comment) | `<string>` | no | | n/a |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per dbt-labs/dbt-snowflake#1081 we removed comment

Suggested change
| [`comment`](#comment) | `<string>` | no | | n/a |


Refreshes the dynamic table at the next scheduled refresh.

### Comment
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per dbt-labs/dbt-snowflake#1081 removing comment

Suggested change
### Comment

Refreshes the dynamic table at the next scheduled refresh.

### Comment
Specifies a comment for the dynamic table.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

per dbt-labs/dbt-snowflake#1081 removing comment

Suggested change
Specifies a comment for the dynamic table.

@HenkvanDyk HenkvanDyk closed this Oct 25, 2024
@HenkvanDyk
Copy link
Author

docs added here:
#5678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants