update VCS and postgres PL docs for accuracy and completeness #4782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
content
aaronbini
approved these changes
Jan 23, 2024
|
|
||
| When you have been notified that the resources are provisioned within the dbt Cloud environment, you must accept the endpoint connection (unless the VPC Endpoint Service is set to auto-accept connection requests). Requests can be accepted through the AWS console, as seen below, or through the AWS CLI. | ||
|
|
||
| <Lightbox src="/img/docs/dbt-cloud/cloud-configuring-dbt-cloud/accept-request.png" width="80%" title="Accept the connection request" /> |
There was a problem hiding this comment.
Is the endpoint ID in this doc sensitive - does it need to be obfuscated or is it ok as-is?
Correct header spacing Co-authored-by: Matt Shaver <[email protected]>
|
|
||
| <Lightbox src="/img/docs/dbt-cloud/cloud-configuring-dbt-cloud/vpc-endpoint-service-name.png" width="80%" title="Location of the VPC Endpoint Service name in the AWS console" /> | ||
|
|
||
| - **DNS configuration:** If the connection to the VCS service requires a custom domain and/or URL for TLS, a private hosted zone can be configured by the dbt Labs Infrastructure team in the dbt Cloud private network. For example: | ||
| ### NOTE: Custom DNS configuration |
There was a problem hiding this comment.
We don't style Note: in header formats. Is it ok if I change this to a callout?
…docs.getdbt.com into update-vcs-privatelink-details
github-actions
bot
added
size: medium
matthewshaver
approved these changes
Jan 24, 2024
Spacing might be causing rendering issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you changing in this pull request and why?
Noticed an incorrect principal ARN and some missing information in a couple of the PrivateLink docs, so updating them accordingly. In summary:
Checklist