Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci-jobs.md #4771

Merged
merged 8 commits into from
Feb 8, 2024
Merged

Update ci-jobs.md #4771

merged 8 commits into from
Feb 8, 2024

Conversation

Tonayya
Copy link
Contributor

@Tonayya Tonayya commented Jan 19, 2024

What are you changing in this pull request and why?

Added a suggestion on a recently reported issue with CI job run status update as per this Zendesk ticket. Please let me know if you'd like the contents of the correspondence in the ticket to be shared. This has been tried, tested and confirmed internally. Please also advise on the text formatting, if any changes need to be made. Thanks team!

Checklist

Added a suggestion on a recently reported issue with CI job run status update as per [this Zendesk ticket](https://dbtcloud.zendesk.com/agent/tickets/60166). Please let me know if you'd like the contents of the correspondence in the ticket to be shared. This has been tried, tested and confirmed internally.
@Tonayya Tonayya requested a review from a team as a code owner January 19, 2024 04:18
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 10:09pm

@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 19, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Feb 8, 2024

hey @Tonayya , thanks for opening this up and happy to review this!

cc @nghi-ly I'm wondering if we should turn all the 'details' block toggles into the detailsToggle component? let me know if you're ok with that and I'll make that change in this pr.

Screenshot 2024-02-08 at 14 53 05

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Feb 8, 2024
@mirnawong1
Copy link
Contributor

review complete and made some tweaks, thank you so much @Tonayya ! Screenshot 2024-02-08 at 14 53 56

@nghi-ly
Copy link
Contributor

nghi-ly commented Feb 8, 2024

@mirnawong1 : yes, please! love the detailsToggle idea!

@github-actions github-actions bot added size: medium This change will take up to a week to address and removed size: small This change will take 1 to 2 days to address labels Feb 8, 2024
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks so much @Tonayya !

@mirnawong1 mirnawong1 merged commit 5ca1113 into current Feb 8, 2024
4 checks passed
@mirnawong1 mirnawong1 deleted the Tonayya-patch-1 branch February 8, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto update content Improvements or additions to content February-2024 size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants