Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _adapters-verified.md #4752

Closed
wants to merge 1 commit into from
Closed

Conversation

ng-hiep
Copy link

@ng-hiep ng-hiep commented Jan 16, 2024

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@ng-hiep ng-hiep requested a review from a team as a code owner January 16, 2024 09:12
Copy link

welcome bot commented Jan 16, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 9:17am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 16, 2024
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 16, 2024
@matthewshaver
Copy link
Contributor

Thank you for your contribution here @ntphiep ! We don't currently have icons for Spark and Postgres, but that's an oversight on our part. I'll work with our design team to get those created prior to merging this

@nghi-ly nghi-ly mentioned this pull request Mar 8, 2024
2 tasks
@nghi-ly
Copy link
Contributor

nghi-ly commented Mar 8, 2024

thanks for opening this PR, @ntphiep ! great catch 🦅 👁️

we recently updated some of our adapter-related files and this snippet has been removed. inspired by your flag, i've opened PR #5050 to fix it in our "trusted" snippet file.

@nghi-ly nghi-ly closed this Mar 8, 2024
nghi-ly added a commit that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants