Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date in article because it affects sort order #4749

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

adrianbr
Copy link
Contributor

No description provided.

Copy link

welcome bot commented Jan 15, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 22, 2024 9:43am

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 15, 2024
@github-actions github-actions bot added developer blog This content fits on the developer blog. size: x-small This change will take under 3 hours to fix. labels Jan 15, 2024
@mirnawong1
Copy link
Contributor

hey @adrianbr thanks for opening up your first PR! can you say little more about what issue you're experiencing with the blog? the page doesn't really have a sort so would love to understand what you're experiencing! thnk you!

@adrianbr
Copy link
Contributor Author

@mirnawong1 the page sorts by time of article. We created an article in Dec 2023 and I guess they wanted to update the date to Jan 2024 but instead they did jan 2023, which causes the article to be burried and not visible among the latest articles

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for clarifying @adrianbr and i understand what you're saying! approving and merging for you so the order is updated and correct - thank you again ✨!

original here; #4658

@mirnawong1 mirnawong1 merged commit 4c84b81 into dbt-labs:current Jan 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer blog This content fits on the developer blog. January-2024 new contributor Label for first-time contributors size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants