Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about the dbt-risingwave adapter #4747

Merged
merged 19 commits into from
Feb 6, 2024

Conversation

hengm3467
Copy link
Contributor

@hengm3467 hengm3467 commented Jan 15, 2024

What are you changing in this pull request and why?

Add documentation about the dbt-risingwave adapter. RisingWave is a streaming database that allows users to process and manage streaming data with a PostgreSQL-style experience. For more information about the company and product, see https://risingwave.com/.

The purpose of this adapter is to enable RisingWave users to leverage the powerful capabilities of dbt to manage their stream processing jobs and pipelines in RisingWave. We consider dbt as the right way to unlock stream processing with our product.

This adapter is available on GitHub repo and PyPl.

Checklist

Adding or removing pages (delete if not applicable):

  • Add page in website/sidebars.js
  • Create setup file /docs/core/connect-data-platform/risingwave-setup.md
  • Provide a unique filename for new pages

@hengm3467 hengm3467 requested a review from a team as a code owner January 15, 2024 08:10
Copy link

welcome bot commented Jan 15, 2024

Hello!👋 Thanks for contributing to the dbt product documentation and opening this pull request! ✨
We use Markdown and some HTML to write the dbt product documentation. When writing content, you can use our style guide and content types to understand our writing standards and how we organize information in the dbt product docs.
We'll review your contribution and respond as soon as we can. 😄

Copy link

vercel bot commented Jan 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2024 5:27pm

@runleonarun runleonarun added the new contributor Label for first-time contributors label Jan 15, 2024
@github-actions github-actions bot added content Improvements or additions to content size: medium This change will take up to a week to address new contributor Label for first-time contributors and removed new contributor Label for first-time contributors content Improvements or additions to content labels Jan 15, 2024
@hengm3467
Copy link
Contributor Author

Somehow the preview failed. I couldn't log in to Vercel to see what happened. Please help take a look. Appreciate your help. :)

@hengm3467
Copy link
Contributor Author

@runleonarun Could you please take a look at this PR? I wasn't able to see why the deployment failed in this case. Thanks a lot!

@runleonarun
Copy link
Collaborator

Yes! @hengm3467 Looking now!

Copy link
Collaborator

@JKarlavige JKarlavige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hengm3467, the build failed with a formatting error. I left a comment where the error is coming from. Adjusting that should get the build to complete successfully

@runleonarun
Copy link
Collaborator

@hengm3467 if you could make Amy's suggested changes, we can get this merged for you.

@hengm3467 hengm3467 requested a review from amychen1776 February 5, 2024 03:03
@hengm3467
Copy link
Contributor Author

@amychen1776 @runleonarun Thanks a lot for your help! I've made the changes suggested by Amy. Please take a look again.

Copy link
Collaborator

@amychen1776 amychen1776 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@hengm3467
Copy link
Contributor Author

@JKarlavige I see the formatting issue was fixed. Could you please confirm and, if that's the case, approve this PR? Thanks a lot! :)

@runleonarun
Copy link
Collaborator

Yep the formatting was fixed!

@hengm3467 One tiny thing. You might want to add the adapter to this page too. Then I can approve and merge!

auto-merge was automatically disabled February 6, 2024 02:55

Head branch was pushed to by a user without write access

@hengm3467
Copy link
Contributor Author

Yep the formatting was fixed!

@hengm3467 One tiny thing. You might want to add the adapter to this page too. Then I can approve and merge!

@runleonarun I have just added the adapter to the Community adapters page. Please take a look and let me know if any questions. Thanks for your help! :)

@runleonarun
Copy link
Collaborator

Looks awesome! Thanks for your work @hengm3467 and @amychen1776!

Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@runleonarun runleonarun enabled auto-merge (squash) February 6, 2024 17:21
@runleonarun runleonarun dismissed JKarlavige’s stale review February 6, 2024 17:47

This has been fixed.

@runleonarun runleonarun merged commit 669c492 into dbt-labs:current Feb 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
February-2024 new contributor Label for first-time contributors size: medium This change will take up to a week to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants