Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ellipses #4744

Merged
merged 2 commits into from
Jan 12, 2024
Merged

remove ellipses #4744

merged 2 commits into from
Jan 12, 2024

Conversation

mirnawong1
Copy link
Contributor

removing ellipses per slack feedback as they were causing errors.

@mirnawong1
remove ellipses
e6d56c7 
removing ellipses per slack feedback as they were causing errors.
@mirnawong1 mirnawong1 requested a review from a team as a code owner January 12, 2024 17:21
@vercel Vercel
Copy link

vercel bot commented Jan 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 12, 2024 5:35pm

@mirnawong1 mirnawong1 enabled auto-merge January 12, 2024 17:21
@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: x-small This change will take under 3 hours to fix. labels Jan 12, 2024
runleonarun
runleonarun approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@runleonarun runleonarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for adding the code comment.

@mirnawong1 mirnawong1 merged commit 8bb6752 into current Jan 12, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the mirnawong1-patch-12 branch January 12, 2024 17:35
cesher
cesher approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@cesher cesher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mirnawong1
Copy link
Contributor Author

thank you for the question @runleonarun !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cesher cesher cesher approved these changes

@runleonarun runleonarun runleonarun approved these changes

Assignees
No one assigned
Labels
auto update content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirnawong1 @runleonarun @cesher