Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clarify snowflake qs steps #4739

Closed
wants to merge 12 commits into from
Closed

clarify snowflake qs steps #4739

wants to merge 12 commits into from

Conversation

mirnawong1
Copy link
Contributor

per user feedback, this pr sets to clarify the followign:

  • role in dev credentials must be specified, otherwise you won't be able to query data in ide
  • clarifies that you have to create a new branch after initializing project.

this pr also prompted me to raise the following questions for clarification:

  • is role really optional? based on my testing, it seems like it's required in the dev credential settings.
  • it seems transformer isn't accepted (at least for me) and it shoudl be transform.

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 12, 2024 12:22
@vercel Vercel
Copy link

vercel bot commented Jan 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 2:06pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Jan 12, 2024
@mirnawong1 mirnawong1 marked this pull request as draft March 13, 2024 11:40
nataliefiann
nataliefiann approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1 this looks great!

I have no suggestions for this. I've approved this for you.

Kind Regards
Natalie

@mirnawong1 mirnawong1 marked this pull request as ready for review June 3, 2024 10:15
@github-actions github-actions bot added size: small This change will take 1 to 2 days to address and removed size: x-small This change will take under 3 hours to fix. labels Jun 3, 2024
@mirnawong1
Update snowflake-qs.md
11a6ebb 
update steps to current version
@github-actions github-actions bot added size: x-small This change will take under 3 hours to fix. and removed size: small This change will take 1 to 2 days to address labels Jun 3, 2024
@matthewshaver
Copy link
Contributor

@mirnawong1 is this ready to merge?

@mirnawong1
Copy link
Contributor Author

will give it a looksie next week!

@mirnawong1
Copy link
Contributor Author

closing PR as it's stale. if necessary, we can reopen

@mirnawong1 mirnawong1 closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliefiann nataliefiann nataliefiann approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mirnawong1 @matthewshaver @nataliefiann