Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _enterprise-permissions-table.md #4728

Merged
merged 8 commits into from
Apr 11, 2024
Merged

Update _enterprise-permissions-table.md #4728

merged 8 commits into from
Apr 11, 2024

Conversation

BrJan
Copy link
Contributor

@BrJan BrJan commented Jan 9, 2024

Fixed project permissions at the project level. Specifically, the docs show Analyst and Developer as having projects_write, but they only have projects_read

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

Fixed project permissions at the project level
@BrJan BrJan requested a review from a team as a code owner January 9, 2024 22:01
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 9:02pm

@BrJan BrJan requested a review from aaronbini January 9, 2024 22:01
@github-actions github-actions bot added content Improvements or additions to content size: x-small This change will take under 3 hours to fix. labels Jan 9, 2024
@@ -84,7 +84,7 @@ The project roles enable you to work within the projects in various capacities.
| Metadata | R | R | R | R | R | R | R | R | | R | R | |
| Permissions | W | | R | R | R | | | | | | W | |
| Profile | W | R | W | R | R | R | | | | R | R | |
| Projects | W | W | W | W | W | R | R | | | R | W | |
| Projects | W | R | R | R | R | R | R | | | R | R | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in dbt-cloud code, what I see is Admin, Database Admin, Git Admin, and Team Admin all have Project write permission

@mirnawong1
Copy link
Contributor

hi team, does this PR still need work? or is it good to merge once the conflicts are fixed?

@mirnawong1
Copy link
Contributor

hey @BrJan and @aaronbini - wanted to follow up on this pr and see if it's still needed?

@aaronbini
Copy link
Contributor

aaronbini commented Mar 28, 2024

hey @BrJan and @aaronbini - wanted to follow up on this pr and see if it's still needed?

@mirnawong1 yes we should get this reviewed and merged. I added the lates commit, so I shouldn't really review it at this point, will add my team as reviewers.

Copy link
Contributor

@nm0s nm0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't have project_write but they do have project_develop

@mirnawong1
Copy link
Contributor

They don't have project_write but they do have project_develop

hey @nm0s thanks so much! so analyst and developer have project develop? does that mean the same thing as 'project read'? or did you mean that comment for Aaron's comment here?

@mirnawong1
Copy link
Contributor

merging pr per convohere w @matthewshaver who addressed my explicit question

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mirnawong1 mirnawong1 merged commit e50323c into current Apr 11, 2024
11 checks passed
@mirnawong1 mirnawong1 deleted the BrJan-patch-2 branch April 11, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants