Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add conversion-metrics-docs #4724

Merged
merged 53 commits into from
Jan 16, 2024
Merged

add conversion-metrics-docs #4724

merged 53 commits into from
Jan 16, 2024

Conversation

mirnawong1
Copy link
Contributor

What are you changing in this pull request and why?

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/static/_redirects
  • Run link testing locally with npm run build to update the links that point to deleted pages

@mirnawong1 mirnawong1 requested a review from a team as a code owner January 9, 2024 10:33
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 2:43am

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: large This change will more than a week to address and might require more than one person and removed Docs team Authored by the Docs team @dbt Labs labels Jan 9, 2024
@github-actions github-actions bot added Docs team Authored by the Docs team @dbt Labs and removed Docs team Authored by the Docs team @dbt Labs labels Jan 9, 2024
@github-actions github-actions bot added the Docs team Authored by the Docs team @dbt Labs label Jan 9, 2024
@WilliamDee
Copy link
Contributor

@mirnawong1 should we add conversion metric hyperlink here

@mirnawong1
Copy link
Contributor Author

@mirnawong1 should we add conversion metric hyperlink here

bloody hell amazing catch @WilliamDee ! nice one and I'll add it there 🙏

@Jstein77
Update conversion-metrics.md
4e31618 
update metric to match image
@Jstein77 Jstein77 enabled auto-merge January 16, 2024 02:39
@Jstein77 Jstein77 merged commit 32d7b1d into current Jan 16, 2024
7 checks passed
@Jstein77 Jstein77 deleted the js-conversion-metrics branch January 16, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamDee WilliamDee WilliamDee left review comments

@matthewshaver matthewshaver matthewshaver approved these changes

@Jstein77 Jstein77 Jstein77 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs January-2024 size: large This change will more than a week to address and might require more than one person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mirnawong1 @WilliamDee @Jstein77 @matthewshaver @runleonarun