Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example for saved queries #4720

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Fix example for saved queries #4720

merged 2 commits into from
Jan 9, 2024

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jan 8, 2024 •
edited
Loading

Preview

What are you changing in this pull request and why?

When I tried the example as-is, I got the following error:

Parsing Error
  The schema file at models/_properties.yml is invalid because the value of 'saved_queries' is not a list

But when I changed it to this, it worked:

saved_queries:
  - name: p0_booking
    description: Booking-related metrics that are of the highest priority.
    query_params:
    ...

Checklist

@dbeatty10 dbeatty10 requested a review from a team as a code owner January 8, 2024 18:12
@vercel Vercel
Copy link

vercel bot commented Jan 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 9, 2024 0:19am

@github-actions github-actions bot added content Improvements or additions to content size: small This change will take 1 to 2 days to address labels Jan 8, 2024
mirnawong1
mirnawong1 approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank, thank you for opening this up and fixing it @dbeatty10 !

@mirnawong1 mirnawong1 enabled auto-merge January 9, 2024 12:13
@mirnawong1 mirnawong1 merged commit 48f3771 into current Jan 9, 2024
7 checks passed
@mirnawong1 mirnawong1 deleted the dbeatty/saved-queries-example branch January 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirnawong1 mirnawong1 mirnawong1 approved these changes

Assignees
No one assigned
Labels
content Improvements or additions to content January-2024 size: small This change will take 1 to 2 days to address
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbeatty10 @mirnawong1 @runleonarun